deis / builder

Git server and application builder for Deis Workflow
https://deis.com
MIT License
40 stars 41 forks source link

fix(builder): add status messages #61

Closed arschles closed 8 years ago

arschles commented 8 years ago

Without these messages, the user may have to wait for a while before the builder pod spins up and the slug runner spins up (respectively).

This is an optional patch for v2.0-alpha1.

Fixes #64

slack commented 8 years ago

This should goooo innnnnnnnnnnn, need another LGTM.

carmstrong commented 8 years ago

LGTM3

slack commented 8 years ago

3TGM, WHERE ARE YOU!>?!?!?

arschles commented 8 years ago

not gonna merge this until after alpha is shipped ;)

slack commented 8 years ago

What if I add the showstopper label?

arschles commented 8 years ago

Oooh, you're playing hardball I see...

arschles commented 8 years ago

it seems like so small a change that it couldn't hurt anything. I'm just paranoid after https://github.com/deis/minio/pull/39

slack commented 8 years ago

What could go wrong!??!! I think the UX is bad enough that we should bring this in.

arschles commented 8 years ago

@slack have you tested it recently? Last time I did was at least 10 days ago

arschles commented 8 years ago

kidding..... pushing the green button

slack commented 8 years ago

:champagne: !