search

deis / builder

Git server and application builder for Deis Workflow
https://deis.com
MIT License
40 stars 41 forks source link

Handle outside storage env variable #62

Closed smothiki closed 8 years ago

smothiki commented 8 years ago

When outside storage env variable is set . We still keep secret mounts in deis-slugrunner and deis-dockerbuilder pods. Unless outside storage requires secrets we should be removing secret mounts from pod yamls

arschles commented 8 years ago

This issue will expand in scope if we add RiakCS to the list of object storage options. Regardless, we'll need to have a lookup order and for various options, not check for secrets...

smothiki commented 8 years ago

The new builder code checks for credentials are present or not then add secret mounts . This issue is resolved