search

deis / builder

Git server and application builder for Deis Workflow
https://deis.com
MIT License
40 stars 41 forks source link

Fix race condition while attempting to stream logs from the builder pod. #65

Closed slack closed 8 years ago

slack commented 8 years ago

https://github.com/deis/builder/blob/daac4b822a94554799c8503e5e7662592492b7f0/rootfs/etc/confd/templates/builder#L139

Is very prone to race conditions. If the builder pod either never makes it to Running or transitions through Running to Terminated we might hang forever.

arschles commented 8 years ago

after #72 is done, we should use the k8s API client directly and watch the event stream instead of polling kubectl