feat(logger): Add redis instance for use by logger

deis / charts

(OBSOLETE) Helm Classic v1 Charts for Deis Workflow

https://deis.com/workflow/

MIT License

45 stars 36 forks source link

feat(logger): Add redis instance for use by logger #293

Closed krancour closed 8 years ago

krancour commented 8 years ago

Depends on https://github.com/deis/logger/pull/88

deis-bot commented 8 years ago

@smothiki, @kmala and @arschles are potential reviewers of this pull request based on my analysis of git blame information. Thanks @krancour!

krancour commented 8 years ago

Only using an off-cluster redis instance (e.g. elasticache) requires manual testing.

arschles commented 8 years ago

I think this looks good, so LGTMing it. I did not test off-cluster redis, however

krancour commented 8 years ago

Amended with some cleaner syntax in templates and some bug fixes.

jchauncey commented 8 years ago

When we merge this PR we should hook up redis to telegraf and create dashboards in grafana

arschles commented 8 years ago

The following should occur before we merge this PR:

The monitoring stack should collect redis metrics (Telegraf has a redis input plugin cc/ @jchauncey)
We should add documentation indicating that logger instances (configured to write to redis) can be added w/o messing up log persistence

... as per offline discussion

jchauncey commented 8 years ago

Few things: 1) Add redis to the list of installed components in the Chart.yaml 2) Document the environment variables that need to be set for off-cluster storage

jchauncey commented 8 years ago

@krancour this is ready to go

sgoings commented 8 years ago

@krancour I made a comment on https://github.com/deis/monitor/pull/119#discussion_r70464486... I'd like to hear your thoughts.