search

deis / charts

(OBSOLETE) Helm Classic v1 Charts for Deis Workflow
https://deis.com/workflow/
MIT License
45 stars 36 forks source link

Router change requires us to move monitor stack to deployments #329

Closed jchauncey closed 8 years ago

jchauncey commented 8 years ago

https://github.com/deis/router/commit/571dfeacb2fbd1ee21645a1de42d18c103288ad3

krancour commented 8 years ago

@jchauncey I don't think this is actually the case.

The commit you're referencing transitions router from looking at it's own RC's annotations to looking at it's own deployment's annotations for discovering it's own configuration.

With respect to all routable services, router still determines configuration by looking at annotations on services with the label routable=true.

So, I don't believe any change to the monitoring stack is strictly required to accommodate this.

That being said, I think there are many components (monitor components being among them) that should move to deployments simply for the sake of consistency. See #337

mboersma commented 8 years ago

I don't believe any change to the monitoring stack is strictly required

I'm moving this to the next milestone then, but please feel free to close it if #337 covers everything.

jchauncey commented 8 years ago

yeah this ended up being a different problem. Will open a new issue to track the work of converting monitor/logging stack to deployments