search

deis / charts

(OBSOLETE) Helm Classic v1 Charts for Deis Workflow
https://deis.com/workflow/
MIT License
45 stars 36 forks source link

Support option for enabling PROXY protocol if on AWS #334

Closed krancour closed 7 years ago

krancour commented 8 years ago

k8s added AWS-specific support for a service.beta.kubernetes.io/aws-load-balancer-proxy-protocol somewhat recently.

The chart doesn't have any awareness of which cloud it's being installed into (i.e. AWS vs GKE vs other), nor does it have any awareness of what version of k8s is in play, so we can't quite opt into this automatically where supported, but we could expose an option in generate_params.toml whereby modifying a single value enables PROXY protocol on both the ELB and the router. (PROXY protocol must always be either enabled in both places or disabled in both places.)

krancour commented 7 years ago

I'm going to close this. If there's further interest in this, it should be re-opened against https://github.com/deis/router since the chart lives there now.