deis / charts

(OBSOLETE) Helm Classic v1 Charts for Deis Workflow
https://deis.com/workflow/
MIT License
45 stars 36 forks source link

ref(workflow-dev): change container port for the router to 80 and 443 #341

Closed bacongobbler closed 8 years ago

bacongobbler commented 8 years ago

see deis/router#239

deis-bot commented 8 years ago

@krancour, @sgoings and @mboersma are potential reviewers of this pull request based on my analysis of git blame information. Thanks @bacongobbler!

krancour commented 8 years ago

Why is this changing? Did the ports within the router container change? If they did, I have to assume the router is running as root now, and I would have to once again articulate the security concerns that arise from running containerized processes as root.

bacongobbler commented 8 years ago

Yes, and I explained my (wip) thoughts in deis/router#239.