search

deis / charts

(OBSOLETE) Helm Classic v1 Charts for Deis Workflow
https://deis.com/workflow/
MIT License
45 stars 36 forks source link

feat(monitor): Make grafana credentials configurable #353

Closed wearethefoos closed 8 years ago

wearethefoos commented 8 years ago

In the docs for Grafana it states:

The default username/password of admin/admin can be overridden at any time by setting the following environment variables in $CHART_HOME/workspace/workflow-$WORKFLOW_RELEASE/manifests/deis-monitor-grafana-rc.yaml: GRAFANA_USER and GRAFANA_PASSWD.

For us it would be great if this was configurable via the template and/or environment variables.

This pull should make both options available.

I'd gladly make a pull as well for the docs, e.g:

The default username/password of admin/admin can be overridden at any time by setting the following environment variables: GRAFANA_USER and GRAFANA_PASSWD or by editing the default parameters in generate_params.toml before running helmc generate.

Let me know if this is a way to go, or if I need to do anything differently!

Cheers.

deis-bot commented 8 years ago

@mboersma is a potential reviewer of this pull request based on my analysis of git blame information. Thanks @foxycoder!

bacongobbler commented 8 years ago

Hey @foxycoder, would you mind making this change against the workflow-dev chart instead? We intentionally keep the release charts as-is and just roll new features into workflow-dev, which will then be rolled into the next release.

wearethefoos commented 8 years ago

@bacongobbler makes total sense! Sorry will do :)

wearethefoos commented 8 years ago

@bacongobbler I moved the changes to workflow-dev chart. Let me know if you guys need anything else.