feat(monitor): Allow for off cluster influxdb

deis / charts

(OBSOLETE) Helm Classic v1 Charts for Deis Workflow

https://deis.com/workflow/

MIT License

45 stars 36 forks source link

Closed jchauncey closed 8 years ago

jchauncey commented 8 years ago

Test steps:

clone PR
In generate_params.toml
- Mark the property influxdb_location as off-cluster
- Add values under influxdb for url, user, password, and database
run helm generate
verify that configuration values were inserted into manifests/deis-monitor-telegraf-daemon.yaml and manifests/deis-monitor-grafana-deployment.yaml

deis-bot commented 8 years ago

@kmala and @jackfrancis are potential reviewers of this pull request based on my analysis of git blame information. Thanks @jchauncey!

mboersma commented 8 years ago

After helmc generate, the URL is enclosed by escaped quotes in manifests/deis-monitor-telegraf-daemon.yaml:

          - name: "INFLUXDB_URLS"
            value: "\"deis.rocks\""

But they don't show up in manifests/deis-monitor-grafana-deployment.yaml:

        - name: "INFLUXDB_SERVICE_URL"
          value: "deis.rocks"

Assuming that's intentional, everything looks good.

jchauncey commented 8 years ago

So the escaped quotes are there so we actually quote the string when it gets passed to telegraf.