search

deis / controller

Deis Workflow Controller (API)
https://deis.com
MIT License
41 stars 53 forks source link

Proposal feat(controller): allow deis pull from deis-registry #1227

Open deis-admin opened 7 years ago

deis-admin commented 7 years ago

From @aledbf on March 20, 2015 1:7

Something like

deis pull —from-internal-registry application-a:version -a application-b

to allow the deploy in application-b from application-a without using internal ip addresses

Copied from original issue: deis/deis#3341

deis-admin commented 7 years ago

From @mboersma on March 26, 2015 22:2

This could also be a use case for deis push, and we would rather add new functionality to that than on top of deis pull I think.

deis-admin commented 7 years ago

From @babarinde on April 15, 2015 12:40

This s really a needed feature. Thanks for the work @aledbf @mboersma Can I Pull (and Push ) from the deis-registry from a coreos node in the cluster ? Also if i do deis pull example.com:5000/image:v2 -a app Is this good practice as against using the Internal Ip of the registry

deis-admin commented 7 years ago

From @aledbf on April 15, 2015 12:52

@babarinde the idea of this proposal is to avoid the search of the ip inside the cluster where the registry is running.

Can I Pull (and Push ) from the deis-registry from a coreos node in the cluster ?

yes, just use the ip inside the cluster docker pull <ip>:5000/app:vXX

Also if i do deis pull example.com:5000/image:v2 -a app

that's the idea of deis pull :) (http://deis.io/demo-deis-pull-in-action/)

Is this good practice as against using the Internal Ip of the registry

I don't know if is a "good practice" but for me solves a huge problem (have 1 app as "template" and N "copies", is useful to pull from the cluster without any external connection)

deis-admin commented 7 years ago

From @babarinde on April 16, 2015 7:23

@aledbf

that's the idea of deis pull :) (http://deis.io/demo-deis-pull-in-action/)

How does deis resolve example.com:5000 to the internal IP of the registry when the registry is not scaled to 3?

deis-admin commented 7 years ago

From @aledbf on April 16, 2015 13:9

How does deis resolve example.com:5000 to the internal IP of the registry when the registry is not scaled to 3?

If you do not specify a full hostname:port deis pull will use the public docker registry to retrieve the image. Remember that this is a proposal to change that behavior.

Now how deis resolve the registry if there's more than one is the easy part :) check with etcdctl ls --recursive /deis/registry the key /deis/registry/host contains the registry that is acting as "master" (you can have multiple registries in the cluster but only one is used to pull/push)

Cryptophobia commented 6 years ago

This issue was moved to teamhephy/controller#32