bacongobbler commented 7 years ago

On some providers, "localhost" is not set up on the host network. explicitly calling the loopback address fixes this.

See https://github.com/deis/workflow/issues/678

codecov-io commented 7 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@bdb5acd).

@@            Coverage Diff            @@
##             master    #1239   +/-   ##
=========================================
  Coverage          ?   87.29%           
=========================================
  Files             ?       43           
  Lines             ?     3826           
  Branches          ?      665           
=========================================
  Hits              ?     3340           
  Misses            ?      321           
  Partials          ?      165

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bdb5acd...1d719b0. Read the comment docs.

vdice commented 7 years ago

Tested by editing controller and builder deployments with this change. (kubectl edit deploy deis-builder -n deis, etc.)

Deploying a Dockerfile-based app (and using local registry) now works.

deis / controller

fix(charts): reference registry-proxy on 127.0.0.1 #1239

Codecov Report