search

deis / controller

Deis Workflow Controller (API)
https://deis.com
MIT License
41 stars 53 forks source link

fix(app.py): use current namespace instead of "deis" #1247

Closed mboersma closed 7 years ago

mboersma commented 7 years ago

Uses the k8s downward api to make the current namespace available to controller so it isn't hard-coded as "deis."

Closes #1246. Closes deis/charts#18. Closes deis/builder#483.

codecov-io commented 7 years ago

Codecov Report

Merging #1247 into master will increase coverage by <.01%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1247      +/-   ##
==========================================
+ Coverage   87.21%   87.21%   +<.01%     
==========================================
  Files          44       44              
  Lines        3872     3873       +1     
  Branches      673      673              
==========================================
+ Hits         3377     3378       +1     
  Misses        326      326              
  Partials      169      169

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4e83f4d...8480f69. Read the comment docs.

krisnova commented 7 years ago

LGTM - Thanks @mboersma!