deis / controller

Deis Workflow Controller (API)
https://deis.com
MIT License
41 stars 53 forks source link

feat(config.py): Add ability to setup default tags for applications #1249

Closed rvadim closed 7 years ago

rvadim commented 7 years ago

We have big enough k8s cluster with many nodes, some parts of nodes very specific and also have specific labels (another version of docker, perf test nodes, etc). So in this situation all of our users need to set tag like "role=worker", it's not very good. And sometimes we detect applications w/o tags working on nodes where it should not.

docs: https://github.com/deis/workflow/pull/750

deis-admin commented 7 years ago

Thanks for the contribution! Please ensure your commits follow our style guide. This code will be tested once a Deis maintainer reviews it.

codecov-io commented 7 years ago

Codecov Report

Merging #1249 into master will increase coverage by 0.03%. The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master    #1249      +/-   ##
==========================================
+ Coverage   87.21%   87.25%   +0.03%     
==========================================
  Files          44       44              
  Lines        3873     3883      +10     
  Branches      673      674       +1     
==========================================
+ Hits         3378     3388      +10     
- Misses        326      327       +1     
+ Partials      169      168       -1

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0685227...f2f1cf8. Read the comment docs.

mboersma commented 7 years ago

Jenkins, add to whitelist.

vdice commented 7 years ago

Also, rebase needed it appears.

vdice commented 7 years ago

Jenkins, test this please.

vdice commented 7 years ago

Apologies, @rvadim -- master branch in controller was broken for a short amount of time -- a quick rebase is needed (should be trivial) and then we can kick off CI again.

rvadim commented 7 years ago

Rebase done, thank you for review.