search

deis / controller

Deis Workflow Controller (API)
https://deis.com
MIT License
41 stars 53 forks source link

chore(ingress): Adding unit tests #1283

Closed krisnova closed 7 years ago

krisnova commented 7 years ago

Adding unit tests for ingress

Non breaking change

closes https://github.com/deis/controller/issues/1275

deis-bot commented 7 years ago

@bacongobbler, @mboersma and @rvadim are potential reviewers of this pull request based on my analysis of git blame information. Thanks @kris-nova!

bacongobbler commented 7 years ago

looks like make test-style is failing on this PR. Would you mind fixing that up? Thanks!

krisnova commented 7 years ago

Oh dang, thanks @bacongobbler they should be fixed now.

codecov-io commented 7 years ago

Codecov Report

Merging #1283 into master will increase coverage by 0.38%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1283      +/-   ##
==========================================
+ Coverage   86.66%   87.04%   +0.38%     
==========================================
  Files          45       45              
  Lines        3929     3929              
  Branches      681      681              
==========================================
+ Hits         3405     3420      +15     
+ Misses        355      338      -17     
- Partials      169      171       +2

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 092e8fe...960e899. Read the comment docs.