search

deis / controller

Deis Workflow Controller (API)
https://deis.com
MIT License
41 stars 53 forks source link

Missing global settings customization in helm chart #1301

Open felixbuenemann opened 7 years ago

felixbuenemann commented 7 years ago

There is currently no way to set the following global controller environment variables without customizing helm charts:

(Probably more, all of the above can be overridden using the equally named environnment variables in each app.)

It would be great if the controller helm chart had a environment_variables section to allow setting these variables, similar to router.deployment_annotations in the deis/router chart:

controller:
  environment_variables:
    KUBERNETES_DEPLOYMENTS_REVISION_HISTORY_LIMIT: "10"
    KUBERNETES_POD_TERMINATION_GRACE_PERIOD_SECONDS: "60"

Alternatively separate values could be added for each setting, but I think this approach is more flexible and avoids the need to document rarely customized settings.

Cryptophobia commented 6 years ago

This issue was moved to teamhephy/controller#22