search

deis / controller

Deis Workflow Controller (API)
https://deis.com
MIT License
41 stars 53 forks source link

DEIS_DEPLOY_HOOK_URLS too early? #1319

Closed Cryptophobia closed 6 years ago

Cryptophobia commented 6 years ago

Is the DEIS_DEPLOY_HOOK_URLS pretty useless...? The hook actually fires before the deployment starts and in what case would it be ever that useful?

Deis-controller Logs:

172.17.0.8 "POST /v2/apps/testing-application/config HTTP/1.1" 201 5084 "PostmanRuntime/6.1.6"
172.17.0.8 "POST /v2/auth/login/ HTTP/1.1" 200 52 "Typhoeus - https://github.com/typhoeus/typhoeus"
172.17.0.8 "GET /v2/apps/testing-application/releases HTTP/1.1" 200 17307 "Typhoeus - https://github.com/typhoeus/typhoeus"
172.17.0.8 "POST /v2/auth/login/ HTTP/1.1" 200 52 "Typhoeus - https://github.com/typhoeus/typhoeus"
172.17.0.8 "GET /v2/apps/testing-application/releases HTTP/1.1" 200 17307 "Typhoeus - https://github.com/typhoeus/typhoeus"
INFO [testing-application]: config testing-application-2277815 updated
INFO [testing-application]: admin changed DEIS_DEPLOY_TEST
INFO [testing-application]: Deploy hook sent to https://requestb.in/asd89iuowq
INFO Pulling Docker image deis/example-go:latest
INFO Tagging Docker image deis/example-go:latest as 127.0.0.1:5555/testing-application:v54
INFO Pushing Docker image 127.0.0.1:5555/testing-application:v54
INFO Pulling Docker image 127.0.0.1:5555/testing-application:v54
INFO Pulling Docker image 127.0.0.1:5555/testing-application:v54
INFO [testing-application]: adding 5s on to the original 120s timeout to account for the initial delay specified in the liveness / readiness probe
INFO [testing-application]: This deployments overall timeout is 125s - batch timeout is 125s and there are 1 batches to deploy with a total of 1 pods

As you can see from above, the DEIS_DEPLOY_HOOK fires and it does not wait for liveness and readiness probe before firing...

We need a POST_DEIS_DEPLOY_HOOK to fire so that we can do actions with another API that our application might depend on. What was the idea behind the original deploy hook, was it meant just for Slack integrations?

This is a feature request.

Cryptophobia commented 6 years ago

This issue was moved to teamhephy/controller#13