Closed Cryptophobia closed 6 years ago
Thanks for the contribution! Please ensure your commits follow our style guide. This code will be tested once a Deis maintainer reviews it.
Jenkins, add to whitelist.
@mboersma : Fixed the tests. Now I am getting this from Jenkins:
ApplyLayer exit status 1 stdout: stderr: write /usr/lib/python3.5/config-3.5m-x86_64-linux-gnu/libpython3.5m-pic.a: no space left on device
This did finally pass--I worked around the error by adding temporary commands to clean the docker graph up.
This is a pretty ambitious change and honestly we haven't had enough time to review it properly. I'd like to leave it out of the v2.18.0 release but keep the PR open if that's amenable to you @Cryptophobia, so maybe this can be merged into a new community fork of controller when that gets rolling. Let me know what you think.
@mboersma : sounds good. we can add it to the fork but we would still appreciate a review.
This PR has been recreated for the deisthree fork here: https://github.com/deisthree/controller/pull/1
Should we keep this open or close it to track the progress downstream?
We should close this since we're not intending on merging this.
We noticed that the api was giving great exceptions when you make a request that fails, but we would like to store those detailed exceptions up to the release api object for version of the release on which they occurred. Similar to how
failed=True
is available on the release api object, there should be a field calledexception
containing the exception msg from the deis-controller when a release or build fails.Let's say we make a
/scale
post request toPOST http://deis.192.168.99.100.nip.io/v2/apps/testing-application/scale
with the following payload:With this PR, when a release fails this is the example of how the release api response will look:
GET http://deis.192.168.99.100.nip.io/v2/apps/testing-application/releases
With this small change we get a detailed message in the api telling us why a certain release failed that is more detailed than the summary message. As a benefit it is stored on the release API object rather than just given as a response to our API calls: