search

deis / deis

Deis v1, the CoreOS and Docker PaaS: Your PaaS. Your Rules.
https://deis.com/docs/
MIT License
6.05k stars 798 forks source link

Builder sends empty process type to Controller #4816

Closed lorieri closed 7 years ago

lorieri commented 8 years ago

Should builder reject empty process type for buildpacks builds?

When building a java app with no procfile:

-----> Discovering process types
-----> Compiled slug size is 65M

...

-----> Pushing image to private registry

-----> Launching... 
2015/12/29 13:00:50 failed retrieving config from controller: <h1>Server Error (500)</h1>
To ssh://git@deis.paas.XXXXX:2222/XXXXX.git
* [new branch]      master -> master
$ deis info
=== testlori Application
updated:  2015-12-29T17:28:47UTC
uuid:     9443331f-0f23-40ef-888f-42c966530d6d
created:  2015-12-29T17:28:47UTC
url:      testlori.paas.XXXXX
owner:    lorieri
id:       testlori

=== testlori Processes

=== testlori Domains
bacongobbler commented 8 years ago

@lorieri that is a good point. If the application and the buildpack won't supply a default process type, the builder should not publish the build as it is incomplete.

Marking as a bug/enhancement

bacongobbler commented 7 years ago

closing, let's keep the conversation going in v2 at deis/builder#448

lorieri commented 7 years ago

👍