search

deis / dockerbuilder

Deis dockerbuilder builds your app from a Dockerfile inside a Kubernetes pod, used by Deis Workflow.
https://deis.com
MIT License
17 stars 27 forks source link

feat(tests): Add flake8 linting for python code #91

Closed ultimateboy closed 8 years ago

ultimateboy commented 8 years ago

Fixes #8

deis-bot commented 8 years ago

@kmala, @mboersma and @arschles are potential reviewers of this pull request based on my analysis of git blame information. Thanks @ultimateboy!

Joshua-Anderson commented 8 years ago

Do we want to add this to the .travis.yml so that CI runs it?

ultimateboy commented 8 years ago

Thanks @helgi and @Joshua-Anderson. Comments have been addressed.

Joshua-Anderson commented 8 years ago

Do you know what python version travis-ci defaults to when not using python language builds? I don't know if it matters if we are using python3 or not, but we might want to explicitly select it with source ~/virtualenv/python3.5/bin/activate

helgi commented 8 years ago

I believe they default to 2.7 - This project probably shouldn't have go as the language?

ultimateboy commented 8 years ago

@Joshua-Anderson good catch. I'm not all that familiar with Travis (yet!) but I just changed the language to python and set the version to 2.7. Seems like this code is not quite ready for python 3, so I'll leave that for another PR.

ultimateboy commented 8 years ago

@Joshua-Anderson ahhh, that's good to know! Fixed.