search

deis / etcd

Etcd cluster for Deis v2
http://deis.io
MIT License
12 stars 13 forks source link

fix(glide.yaml): adding version to etcd dependency #12

Closed arschles closed 8 years ago

mboersma commented 8 years ago

LGTM. Should we sync up with etcd 2.2.2 in the Dockerfile too? It's on 2.2.1 currently.

arschles commented 8 years ago

@mboersma not sure how I feel upgrading the etcd version. basically I'm afraid it behaves differently and won't work in a containerized environment (I understand that a lot of work went into getting 2.2.1 working inside docker)

mboersma commented 8 years ago

I'm afraid it behaves differently and won't work

It certainly ought to since it's just a patch release, but understood. Maybe glide should pin github.com/coreos/etcd at v2.2.1 then? (Or am I too preoccupied with consistency here?)

arschles commented 8 years ago

@mboersma you're right, may as well be consistent. pinned in https://github.com/arschles/etcd/commit/7ae58ac6a3b90a5bef3ef473b6478c6539742d11