search

deis / fluentd

Log shipping mechanism for Deis Workflow
https://deis.com
MIT License
10 stars 23 forks source link

ref(Makefile): remove obsolete "docker tag -f" flag #30

Closed mboersma closed 8 years ago

mboersma commented 8 years ago

This is an error with Docker 1.12.

deis-bot commented 8 years ago

@jchauncey and @krancour are potential reviewers of this pull request based on my analysis of git blame information. Thanks @mboersma!

krancour commented 8 years ago

I had tried removing this once before and was told we depend on it, so I want to make sure I understand the implications here. Without this option, our re-tagging of the mutable canary image will not work on Docker < 1.10 (I think), and with it, the same won't work on Docker >= 1.12. Sound right? So 1.10 - 1.12 is the range of Docker versions that will work for us? Do we know that we're safely in that range everywhere that matters?

mboersma commented 8 years ago

My understanding is that tag -f has been the default behavior for a while, and Docker has been nagging about this flag being deprecated for several releases now.

I wanted to fix this to make it compatible with local hacking (most of us got force-fed Docker 1.12 rc yesterday via Docker for Mac), but it shouldn't affect earlier client behavior is my understanding.

Docker v1.10.3 is what is in use on our Jenkins CI / CD setup currently. So I think yes, Workflow supports Docker v1.10 - v1.12, is a safe statement.

bacongobbler commented 8 years ago

I had tried removing this once before and was told we depend on it, so I want to make sure I understand the implications here.

The TL;DR is that a couple months ago we had devs on versions older than Docker 1.10 (I was on docker 1.8 for example). Now that there are several releases out (docker 1.12) and everyone should be on at least docker 1.10, it's safe to upgrade.