search

deis / fluentd

Log shipping mechanism for Deis Workflow
https://deis.com
MIT License
10 stars 23 forks source link

(feat: fluentd): Allow configuring custom plugins/stores/filters for fluentd #40

Closed mattk42 closed 8 years ago

mattk42 commented 8 years ago

This is a first pass at supporting custom plugins, stores, and filters in fluentd. It includes support for installing all of the build dependencies for any plugins that require compilation.

If this is the implementation that ends up being accepted, the documentation should point out that this will significantly increase the pod startup time.

It is implemented fairly simply and controlled by env vars that can be set in the DaemonSet definition:

To enable installing the build tools on startup.

INSTALL_BUILD_TOOLS="true"

To install a plugin, simply set a FLUENTDPLUGIN# env var. Additional flags can be specified here as well

FLUENTDPLUGIN#=

Custom store and filter configs can be supplied in env vars as well.

CUSTOMSTORE#= CUSTOMFILTER#=

bacongobbler commented 8 years ago

LGTM! @mattk42 would you mind adding some documentation in the README so other users who are interested in this feature know how to use it? Thanks!

mattk42 commented 8 years ago

@bacongobbler Sure thing, I will try and get to that today.

jchauncey commented 8 years ago

We saw some issues in CI last night with this PR. So I reverted the commit. I am going to retest this manually today.