search

deis / fluentd

Log shipping mechanism for Deis Workflow
https://deis.com
MIT License
10 stars 23 forks source link

Turn on logstash_format for elasticsearch output #63

Closed sstarcher closed 8 years ago

sstarcher commented 8 years ago

Turn on logstash_format for elasticsearch output to make it more compatible with kibana. This will change the default index from fluentd to logstash-YYYY.MM.DD. This is the default elasticsearch format and is also what Kubernetes fluentd setup also uses.

Docs are - https://github.com/uken/fluent-plugin-elasticsearch#logstash_format Kubernetes setup - https://github.com/kubernetes/kubernetes/blob/master/cluster/addons/fluentd-elasticsearch/fluentd-es-image/td-agent.conf#L259

This makes the ES output much more useful with Kibana.

deis-admin commented 8 years ago

Thanks for the contribution! Please ensure your commits follow our style guide. This code will be tested once a Deis maintainer reviews it.

deis-bot commented 8 years ago

@jchauncey is a potential reviewer of this pull request based on my analysis of git blame information. Thanks @sstarcher!

sstarcher commented 8 years ago

It looks like #60 accomplishes the same thing. I do think it would be preferable for all users of ES to turn the value on by default.