chore(redis): Make pipeline configurable

deis / logger

In-memory log buffer used by Deis Workflow.

https://deis.com

MIT License

18 stars 15 forks source link

chore(redis): Make pipeline configurable #101

Closed krancour closed 8 years ago

krancour commented 8 years ago

At @jchauncey's suggestion, I am making Redis pipelines more configurable in terms of their length and in terms of how long we will queue up messages before executing a pipeline that has not yet reached the configured length. (This is to avoid a large delay in messages reaching Redis when log volumes are low.)

This PR does not change the default values.

codecov-io commented 8 years ago

Current coverage is 41.48%

Merging #101 into master will increase coverage by 0.36%

@@             master       #101   diff @@
==========================================
  Files            10         10          
  Lines           321        323     +2   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            132        134     +2   
  Misses          169        169          
  Partials         20         20

Powered by Codecov. Last updated by 25fb250...7bc332e

arschles commented 8 years ago

https://github.com/deis/logger/pull/101#discussion_r71187210 is not blocking this PR. LGTM2

krancour commented 8 years ago

@arschles I amended the PR as per your suggestion about passing around time.Durations instead of an integer representing seconds. Feel free to re-review.

arschles commented 8 years ago

@krancour cool - still LGTM