feat(pprof): Add pprof endpoint

deis / logger

In-memory log buffer used by Deis Workflow.

https://deis.com

MIT License

18 stars 15 forks source link

feat(pprof): Add pprof endpoint #108

Closed jchauncey closed 8 years ago

jchauncey commented 8 years ago

We will now include a pprof endpoint located at http://0.0.0.0:8099/debug/pprof. This allows user to exec into the running pod and look at debug information like number of executing goroutines and memory profile.

Test Steps:

Clone PR
make build push upgrade into your k8s cluster
kubectl exec into your running logger container.
curl localhost:8099/debug/pprof/heap

You can find more information here - https://golang.org/pkg/net/http/pprof/

deis-bot commented 8 years ago

@krancour is a potential reviewer of this pull request based on my analysis of git blame information. Thanks @jchauncey!

krancour commented 8 years ago

@jchauncey does this additional level of instrumentation have any side effects-- e.g. observer effect?

jchauncey commented 8 years ago

No its only accessed when hit directly. It does sample some data but all blog posts and videos I have watched said it has very little affect on the overall runtime.