feat(ringbuffer): Treat empty ringbuffer as error

deis / logger

In-memory log buffer used by Deis Workflow.

https://deis.com

MIT License

18 stars 15 forks source link

feat(ringbuffer): Treat empty ringbuffer as error #96

Closed krancour closed 8 years ago

krancour commented 8 years ago

cc @arschles @jchauncey

This is a first step toward isolating the as-yet-unexplained scenario we have encountered in load testing where two back-to-back executions of deis logs first return some logs, and then none.

deis-bot commented 8 years ago

@jchauncey is a potential reviewer of this pull request based on my analysis of git blame information. Thanks @krancour!

codecov-io commented 8 years ago

Current coverage is 78.26%

Merging #96 into master will decrease coverage by 0.99%

@@             master        #96   diff @@
==========================================
  Files             3          3          
  Lines           135        138     +3   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            107        108     +1   
- Misses           15         16     +1   
- Partials         13         14     +1

Powered by Codecov. Last updated by 3bf21b8...a369718

arschles commented 8 years ago

@krancour https://github.com/deis/logger/pull/96#discussion_r68310164 and https://github.com/deis/logger/pull/96#discussion_r68310328 are nits, so this code LGTM and I'll mark as such.

@jchauncey is there any way to expose the ring buffer size to the metrics/monitoring system? If so, we should do that here so we can watch the behavior of the ring buffer.