search

deis / logger

In-memory log buffer used by Deis Workflow.
https://deis.com
MIT License
18 stars 15 forks source link

separate redis test from the unit test #99

Open jchauncey opened 8 years ago

jchauncey commented 8 years ago

Since we are having to start an external component we are mixing terms when we call the test suit unit tests. Therefore, we should move the redis tests out to an integration target.

arschles commented 8 years ago

The separation is already done via the testredis build tag. The Makefile enables these tests in its test-unit target (https://github.com/deis/logger/blob/master/Makefile#L119), but the new build target is not in place

jchauncey commented 8 years ago

Yeah but that tag says to run the redis tests. I am saying dont do that as part of test-unit. Instead do that as test-integration

arschles commented 8 years ago

Sorry, that tag is poorly named. It enables the redis tests, which run in addition to all the other tests. Thoughts on these test targets?

test-all:
  // runs all tests, including integration
  $(DOCKER_CMD) go build -tags="testredis" $(glide nv)
test-unit:
  // runs only unit tests, with no external dependencies
  $(DOCKER_CMD) go build $(glide nv)
jchauncey commented 8 years ago

yeah. i would love to be able to just run the integration tests though.

jchauncey commented 8 years ago 
test-all: test-unit test-integration

Is what im thinking we should do

arschles commented 8 years ago

@jchauncey we could add capability to run just integration tests by checking a LOGGER_TEST_INTEGRATION env var in unit tests. If it exists, unit tests should bail out. I can research some other options too.

Cryptophobia commented 6 years ago

This issue was moved to teamhephy/logger#6