search

deis / monitor

Monitoring for Deis Workflow
https://deis.com
MIT License
22 stars 32 forks source link

chore(telegraf): Update manifest to support pulling metrics from redis #119

Closed jchauncey closed 8 years ago

jchauncey commented 8 years ago

This PR adds the ability to monitor our redis instance. Depends on - https://github.com/deis/charts/pull/293

It also updates all of the dashboards to remove some unnecessary fields in the json and clean up their reported versions.

Manual Testing:

  1. Deploy deis using the following chart pr - https://github.com/deis/charts/pull/293
  2. run make build push upgrade within the telegraf directory
  3. run make build push upgrade within the grafana directory
  4. goto grafana.mydomain.com and login admin/admin
  5. Make sure there is a redis dashboard available
  6. Make sure the charts are being populated with information.
deis-bot commented 8 years ago

@sstarcher is a potential reviewer of this pull request based on my analysis of git blame information. Thanks @jchauncey!

sstarcher commented 8 years ago

LGTM - not that it matters ;)

jchauncey commented 8 years ago

Yeah blame bot is an equal opportunity blamer :) On Jul 11, 2016 9:33 PM, "Shane Starcher" notifications@github.com wrote:

LGTM - not that it matters ;)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/deis/monitor/pull/119#issuecomment-231913905, or mute the thread https://github.com/notifications/unsubscribe/AAaRGK_ja9Dm9viQspWpuZ02bfSY7bOQks5qUu7ogaJpZM4JJrJM .

arschles commented 8 years ago

LGTM assuming https://github.com/deis/monitor/pull/119#discussion_r70496850 is addressed

krancour commented 8 years ago

I haven't reviewed the code changes, but I have been using this PR for a couple days and I'm pretty happy with it. The one odd thing I would note is that I am sometimes seeing a number of Redis clients reported that is not a whole number. I'm not sure, for instance, what 4.6 clients might mean.

jchauncey commented 8 years ago

Yeah that value is coming directly from redis so whatever they report we show.

arschles commented 8 years ago

The code (mostly JSON) here looks good to me. I haven't manually tested it and @krancour I know you have, so I'd like you to decide on the final LGTM (I recall you had an issue like https://github.com/deis/monitor/pull/119#issuecomment-232730498 recently, but that's possibly related to https://github.com/deis/charts/pull/304)

arschles commented 8 years ago

Just tested this, but noticed that connected clients is N/A until the logger starts writing to redis. I haven't seen it report anything but 1 so far either, even when I scale up the number of loggers

jchauncey commented 8 years ago

interesting.

arschles commented 8 years ago

Just tested, and got clarification on the graph. Also, I noticed that I had an outdated logbomb running. Once I updated my logbomb, the N/As mostly went away. I was able to repro them one more time (after a simple restart-and-upgrade of grafana), but since then, doing simple restart-in-place of grafana has not resulted in any more N/As.

I'm still LGTM on this patch