search

deis / monitor

Monitoring for Deis Workflow
https://deis.com
MIT License
22 stars 32 forks source link

fix(telegraf) queue always gets created #128

Closed sstarcher closed 8 years ago

sstarcher commented 8 years ago

[ -n $VAL ] does not function without quotes [[ -n $VAL ]] and [ -n "$VAL" ] both work

deis-admin commented 8 years ago

Thanks for the contribution! Please ensure your commits follow our style guide. This code will be tested once a Deis maintainer reviews it.

deis-admin commented 8 years ago

Thanks for the contribution! Please ensure your commits follow our style guide. This code will be tested once a Deis maintainer reviews it.

deis-admin commented 8 years ago

Thanks for the contribution! Please ensure your commits follow our style guide. This code will be tested once a Deis maintainer reviews it.

deis-bot commented 8 years ago

@jchauncey is a potential reviewer of this pull request based on my analysis of git blame information. Thanks @sstarcher!

mboersma commented 8 years ago

Jenkins, add to whitelist.

jchauncey commented 8 years ago

=) this was a last minute change last release so I definitely overlooked if it was actually working the way it should. Good catch.

sstarcher commented 8 years ago

I don't run the entire monitoring system so when I upgraded telegraf to v2.2 it went into a crashback loop ;)