search

deis / monitor

Monitoring for Deis Workflow
https://deis.com
MIT License
22 stars 32 forks source link

chore(telegraf): Allow user to disable disk plugin #154

Closed jchauncey closed 7 years ago

deis-bot commented 7 years ago

@sstarcher is a potential reviewer of this pull request based on my analysis of git blame information. Thanks @jchauncey!

sstarcher commented 7 years ago

Any reason to not follow the same pattern as everything else by using ENABLE {{ if .ENABLE_ETCD }}

jchauncey commented 7 years ago

figured out my problem with coreos and disk. Basically there are certain parts of the filesystem that you cant really father stats for. So I just set DISK_MOUNT_POINTS to ["/"]

jchauncey commented 7 years ago

I want it on by default so made sense to make it implicit without having to put it in the chart.

On Oct 21, 2016 12:26 PM, "Shane Starcher" notifications@github.com wrote:

Any reason to not follow the same pattern as everything else by using ENABLE {{ if .ENABLE_ETCD }}

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/deis/monitor/pull/154#issuecomment-255421116, or mute the thread https://github.com/notifications/unsubscribe-auth/AAaRGODF5M2Qqz_z356ye5Miew8eNaWlks5q2OeZgaJpZM4KdZOU .