search

deis / monitor

Monitoring for Deis Workflow
https://deis.com
MIT License
22 stars 32 forks source link

chore(Dockerfile): update Grafana to 4.0.2 #167

Closed wuvs closed 7 years ago

wuvs commented 7 years ago

new core feature was added for alerts

deis-admin commented 7 years ago

Thanks for the contribution! Please ensure your commits follow our style guide. This code will be tested once a Deis maintainer reviews it.

deis-bot commented 7 years ago

@jchauncey, @helgi and @krancour are potential reviewers of this pull request based on my analysis of git blame information. Thanks @wuvs!

rimusz commented 7 years ago

@jchauncey will grafana v4 work? if it does, I'm happy to provide persistent storage support for influxdb/grafana charts, as we are looking to use grafana v4 too and use it's alerting.

bacongobbler commented 7 years ago

From their blog post:

Upgrade & Breaking changes

There are no breaking changes. Old dashboards and features should work the same. Grafana-server will automatically upgrade it’s db schema on restart. It’s advisable to do a backup of Grafana’s database before updating.

If your are using plugins make sure to update your plugins as some might not work perfectly v4.

You can update plugins using grafana-cli

grafana-cli plugins update-all

As far as I can tell we only add plugins to telegraf so no other action is necessary, though it would be good to get @jchauncey's eyes on this one when he's awake.

bacongobbler commented 7 years ago

If you wouldn't mind amending your commit such that it follows the commit style guide, that would be awesome! That way it'll get picked up by deisrel when we generate the release changelog. Thanks!

jchauncey commented 7 years ago

Yeah going to 4.x shouldnt be an issue as long as they didnt change the json format for dashboards (which i doubt).

mboersma commented 7 years ago

as long as they didnt change the json format for dashboards

This is why we test. :-) I'll give this a go manually.

mboersma commented 7 years ago

A quick smoke test doesn't show any Grafana errors, and things look the same as they did with the previous release. But since we don't have good automated coverage for monitoring changes, we should do more extensive testing to ensure there isn't a subtle issue here before merging it. We've been bitten before.

@wuvs thanks for doing this! Could you git commit --amend the message to something like:

chore(Dockerfile): update Grafana to 4.0.2
vdice commented 7 years ago

All dashboards look just fine when I deploy this change into a local cluster.