search

deis / monitor

Monitoring for Deis Workflow
https://deis.com
MIT License
22 stars 32 forks source link

chore(Dockerfile): update Influxdb to 1.1.1 #168

Closed rimusz closed 7 years ago

deis-bot commented 7 years ago

@sstarcher, @krancour and @jchauncey are potential reviewers of this pull request based on my analysis of git blame information. Thanks @rimusz!

sstarcher commented 7 years ago

LGTM

bacongobbler commented 7 years ago

From the 1.1.0 release notes:

Configuration Changes

The following configuration changes may need to changed before upgrading to 1.1.0 from prior versions.

[admin] Section

enabled now default to false. If you are currently using the admin interaface, you will need to change this value to true to re-enable it. The admin interface is currently deprecated and will be removed in a subsequent release.

[data] Section

  • cache-max-memory-size has been increased to from 524288000 to 1048576000. This setting is the maximum amount of RAM, in bytes, a shard cache can use before it rejects writes with an error. Setting this value to 0 disables the limit.
  • cache-snapshot-write-cold-duration has been decreased from 1h to 10m. This setting determines how long values will stay in the shard cache while the shard is cold for writes.
  • compact-full-write-cold-duration has been decreased from 24h to 4h. The shorter duration allows cold shards to be compacted to an optimal state more quickly.

Can you please change the [admin] section such that it is disabled by default, and update the fields in the [data] section here: https://github.com/deis/monitor/blob/master/influxdb/rootfs/home/influxdb/config.toml.tpl

bacongobbler commented 7 years ago

ping

rimusz commented 7 years ago

so how missed your comment, will do that tomorrow

rimusz commented 7 years ago

no idea whats wrong with github today, cannot see my latest changes v1.1.1, going to open another PR and close this one

rimusz commented 7 years ago

closing in favour of #174