search

deis / monitor

Monitoring for Deis Workflow
https://deis.com
MIT License
22 stars 32 forks source link

ref(ci): refactor monitor ci #184

Closed vdice closed 7 years ago

vdice commented 7 years ago

Consolidate refactored make logic for monitor components into default.mk; Introduce test and test-style targets for running shellcheck against bash scripts; Remove deprecated/unused _scripts and manifests directories

vdice commented 7 years ago

Note on manual testing: I've tested by running the following make targets (once Workflow is installed and kubectl is pointing to the right cluster),

cd telegraf; make test deploy
cd influxdb; make test deploy
cd grafana; make test deploy

As well as smoke testing the monitoring stack, 

open http://grafana.<workflow router ip>.nip.io

logging in, checking out dashboards, etc.

I'm sure there are plenty of other scenarios to check, too! (I believe I updated each component's README's properly, but something to check, etc.)

bacongobbler commented 7 years ago

haven't manually tested these changes, but it looks good to me. I'll get onto manual tests now.

bacongobbler commented 7 years ago

manually tested, all works