deis / monitor

Monitoring for Deis Workflow

https://deis.com

MIT License

22 stars 32 forks source link

chore(Dockerfiles): Refactor images to use ubuntu-slim #96

Closed krancour closed 8 years ago

krancour commented 8 years ago

Fixes #90

mention-bot commented 8 years ago

By analyzing the blame information on this pull request, we identified @jchauncey and @sstarcher to be potential reviewers

sstarcher commented 8 years ago

influxdb version is not pinned at a specific version

krancour commented 8 years ago

After some offline discussion, I'm rescinding these LGTMs and will ask for a re-review shortly.

krancour commented 8 years ago

I stead of adding sources to apt-get, I am now downloading version-specific debs, installing from those, then deleting them when done. This can be re-reviewed now.

jchauncey commented 8 years ago

i didnt manually test this but looks good now

arschles commented 8 years ago

Does this fix https://github.com/deis/monitor/issues/90?

krancour commented 8 years ago

90 looks vague. Either it refers to the high severity issues with the official Grafana image we were previously deriving ours from and/or it refers to the fact that our Alpine-based images for telegraf and influxdb weren't being scanned at all.

In either of those cases, I feel this addressed #90. I've update the OP as such.

jchauncey commented 8 years ago

Yeah for now On May 24, 2016 12:29 PM, "Aaron Schlesinger" notifications@github.com wrote:

Does this fix #90 https://github.com/deis/monitor/issues/90?

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/deis/monitor/pull/96#issuecomment-221354470