search

deis / postgres

A PostgreSQL database used by Deis Workflow.
https://deis.com
MIT License
36 stars 22 forks source link

feat: openstack swift support #106

Closed paulczar closed 8 years ago

paulczar commented 8 years ago

Adds support for Openstack Swift as object store backend for backups.

mention-bot commented 8 years ago

By analyzing the blame information on this pull request, we identified @kmala, @bacongobbler and @mboersma to be potential reviewers

deis-admin commented 8 years ago

Thanks for the contribution! Please ensure your commits follow our style guide. This code will be tested once a Deis maintainer reviews it.

bacongobbler commented 8 years ago

Any way we can make the integration tests spawn an openstack swift container and retrieve the credentials from inside it via docker exec? That would make it so we can easily test without having to boot up a swift node every time :)

paulczar commented 8 years ago

@bacongobbler well my thought is that you would test it against a public swift implementation ( rackspace?? ) rather than building one out.

paulczar commented 8 years ago

but I'm sure there's probably a swift image somewhere that somebody has built that we could use.

bacongobbler commented 8 years ago

We'd be more than happy to test against Rackspace. The only reason I ask is because our existing integration tests spawn a minio container and link postgres to that container for testing. I'd love if the whole test suite in #93 was containerized (though I assume Azure Blob Storage is backed by a closed source solution), but perhaps that's just a pipe dream.

Either way I can look into it, but thank you for the PR! We are just about to ship 2.0 so I'm gonna hold off on this for now, but I will get back to this shortly after.

kmala commented 8 years ago

@paulczar can you implement the review comments so that it can be merged

kmala commented 8 years ago

125