search

deis / postgres

A PostgreSQL database used by Deis Workflow.
https://deis.com
MIT License
36 stars 22 forks source link

chore(Dockerfile): consolidate a few chmod and chown into one layer #144

Closed helgi closed 7 years ago

helgi commented 7 years ago

Get gosu from Ubuntu (1.7 gosu) and combine pip installs into one step

It doesn't really matter much but compared to v2.2.2 image this commit is 25mb smaller (includes the latest v0.3.4 image bump)

deis-bot commented 7 years ago

@krancour, @mboersma and @bacongobbler are potential reviewers of this pull request based on my analysis of git blame information. Thanks @helgi!

bacongobbler commented 7 years ago

Personally I'm more in favour of retaining what upstream is doing by installing gosu through the github channels. Any particular reason we want to install through apt?

This would probably be a good thing to PR upstream as well

bacongobbler commented 7 years ago

It appears that the debian gosu is the exact same one, so I guess it doesn't really matter.

helgi commented 7 years ago

What's the point tho? Upstream is at 1.7, Ubuntu is at 1.7 plus important patches. gosu is at 1.9

helgi commented 7 years ago

Oh good then :-)

helgi commented 7 years ago

Closing this so I can PR from my own fork