search

deis / postgres

A PostgreSQL database used by Deis Workflow.
https://deis.com
MIT License
36 stars 22 forks source link

Revert "fix(boto): specify the region while getting s3 connection" #174

Closed bacongobbler closed 7 years ago

bacongobbler commented 7 years ago

This reverts commit 388c593dd182755fad2218ef2c1f24d39bc29948.

While it is the correct thing to do, it is a low severity issue and blocks users from upgrading to v2.9.0 due to #173. Reverting this commit returns the database to looking up and creating buckets in us-east-1. While it isn't optimal, it's not a security/billing issue.

deis-bot commented 7 years ago

@kmala and @paulczar are potential reviewers of this pull request based on my analysis of git blame information. Thanks @bacongobbler!

kmala commented 7 years ago

If this fix is reverted, then new installs doesn't work because we create the bucket in the us-east-1(default region) but the wal-e fails because we pass it a different/actual region passed by the user.

bacongobbler commented 7 years ago

Thanks, I just reverted that change as well.

bacongobbler commented 7 years ago

Also I've added a commit that hardcodes the region to us-east-1 as a stopgap until we fix this in the next release.

bacongobbler commented 7 years ago

this won't work as it misses out the use case where users manually create the buckets in the correct region, so I'm closing this in favour of a better patch.