Closed bacongobbler closed 7 years ago
@kmala and @paulczar are potential reviewers of this pull request based on my analysis of git blame
information. Thanks @bacongobbler!
Nice! I'll test now. You can squash or remove the first commit to clean it up--this is much simpler.
I figured I'd keep your commit in there for credit :) I shall do so now.
fwiw I just manually tested this on an upgrade from v2.8.0 to v2.9.0 + this image and it seems to be working for me.
I also tested on a broken upgraded S3 cluster and this seems to do the trick. Wal-e found its backup and everything recovered (after flapping for two hours with my previous attempt at fixing this).
I'm going to go ahead and merge this as two of us have manually tested these changes and everything works as intended. CI's breaking due to unrelated changes.
continuation of #175. If we fail to create the bucket in the specified region, it means the user has created the bucket in us-east-1 (see #173). We can then assume that we want wal-e to connect to said bucket in us-east-1. I've added a note that we'll want to remove this code once we drop support for v2.8.0 and earlier versions.
closes #173 closes #175