deis / postgres

A PostgreSQL database used by Deis Workflow.
https://deis.com
MIT License
36 stars 22 forks source link

chore(Dockerfile): update deis/base to v0.3.6 #180

Closed bacongobbler closed 7 years ago

bacongobbler commented 7 years ago

Awaiting deis/base:v0.3.6 to be released

mboersma commented 7 years ago

I'm seeing this error when trying to build controller or builder locally after this same change:

Reading package lists...
Building dependency tree...
Reading state information...
0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
gzip: /usr/share/copyrights.tar.gz has 20 other links -- unchanged
tar: Removing leading `/' from member names
tar: Removing leading `/' from hard link targets
gzip: /usr/share/copyrights.tar.gz already exists;  not overwritten

I think the fix in deis/controller#1203 may be pervasive. I'm not sure why CI was able to build these PRs, however--I would have thought it would hit the same issue, but it's consistent for me locally.

mboersma commented 7 years ago

In this case (and probably others), that layer was cached, which prevented this error from showing itself. I think we need to build Docker images with --no-cache.

mboersma commented 7 years ago

LGTM++