Closed greglearns closed 7 years ago
Thanks for the contribution! Please ensure your commits follow our style guide. This code will be tested once a Deis maintainer reviews it.
@bacongobbler and @paulczar are potential reviewers of this pull request based on my analysis of git blame
information. Thanks @greglearns!
... oops, the commit name should have been something like "fix(postgres): block invalid S3 bucket name" according to http://docs.deis.io/en/latest/contributing/standards/#commit-style-guide
Closing: will resubmit with git commit message fixes.
Using a period in BUCKET_NAME causes
helm install -f values.yaml deis/workflow --namespace=deis
to failRELATED ISSUES
https://github.com/deis/workflow/issues/700 https://github.com/deis/workflow/pull/701 (documentation fix)
Note: this bug also exists for https://github.com/deis/registry/blob/master/rootfs/bin/create-bucket#L27
REPRODUCING THE BUG
Using a period in BUCKET_NAME causes
helm install -f values.yaml deis/workflow --namespace=deis
to fail with this error:A POSSIBLE FIX
Not sure how to create a test for this (I just started using Deis 4 days ago), but, a hacky test is this: