search

deis / postgres

A PostgreSQL database used by Deis Workflow.
https://deis.com
MIT License
36 stars 22 forks source link

fix(001_setup_envdir.sh): inspect actual var instead of literal string #186

Closed vdice closed 7 years ago

bacongobbler commented 7 years ago

That would do it. cc @dmcnaught

dmcnaught commented 7 years ago

👍

bacongobbler commented 7 years ago

This also coincides with the story that it didn't work as of v2.9: https://github.com/deis/postgres/pull/167 was merged for v2.9.0.

closes #184

vdice commented 7 years ago

@dmcnaught I didn't realize this fix had broader implications -- does it happen to resolve some or all of the issues in https://github.com/pulls?utf8=%E2%9C%93&q=is%3Aopen+user%3Adeis+milestone%3Av2.11+author%3Admcnaught+ ?

dmcnaught commented 7 years ago

I think it should fix those 3 - my trail to the typo....

bacongobbler commented 7 years ago

yep! That was indeed the source of all of @dmcnaught's grief. Thanks for finding that!

dmcnaught commented 7 years ago

Can't believe I missed it :). Thanks