Closed kmala closed 8 years ago
code LGTM. Have we tested this against S3 or shall I go ahead and test this with https://github.com/deis/charts/pull/127?
I had tested it against s3 and minio.I had created few apps and deleted the database pod and upon starting checked the deis apps:list.
All right if you feel confident with the changes then feel free to merge, then wait for the build on https://travis-ci.org/deis/postgres/builds from the merge to finish then go ahead and merge deis/charts#127. @mboersma was burned the last time I pushed a chart change before the image was updated. :)
For S3 to work we need fix https://github.com/deis/wal-e/pull/1
looks like it's been merged so you should be good to go. :shipit:
Allow postgres to support S3 as storage.