search

deis / postgres

A PostgreSQL database used by Deis Workflow.
https://deis.com
MIT License
36 stars 22 forks source link

the pod is being reported as in a ready state ​before​ the restore completes #55

Closed bacongobbler closed 8 years ago

bacongobbler commented 8 years ago

From Slack:

The restore is still running according to logs i’m tailing… and yet i see this:

$ k get pods
NAME                  READY     STATUS             RESTARTS   AGE
deis-builder-kcc5q    1/1       Running            0          59m
deis-database-azhmf   1/1       Running            2          16m
deis-minio-1k3i1      1/1       Running            0          59m
deis-registry-luse6   1/1       Running            0          59m
deis-router-762v9     1/1       Running            0          59m
deis-workflow-wi4o2   0/1       CrashLoopBackOff   12         59m

ready 1/1, even tho restore is still in flight

This isn't a core issue since client connections will be refused with a "database is busy/in recovery" error, but we should make the health check smarter.

Note that this was something I pointed out in https://github.com/deis/postgres/pull/24#issuecomment-188451981