search

deis / postgres

A PostgreSQL database used by Deis Workflow.
https://deis.com
MIT License
36 stars 22 forks source link

feat(postgres): run periodic backups in the background #58

Closed bacongobbler closed 8 years ago

bacongobbler commented 8 years ago

backup retention and frequency of backups are configurable through environment variables.

Note that this is the exact same script we used in v1, bumping the backup frequency to every 12 hours. Yay portability!

closes #53 closes #32

bacongobbler commented 8 years ago

I'm gonna add integration tests for this so we can verify backups have been shipped to minio. That way nobody needs to test this manually!

bacongobbler commented 8 years ago

found a bug with this: https://github.com/deis/wal-e/issues/2

going to mark as in-progress until that is fixed upstream.

bacongobbler commented 8 years ago

relevant PR: https://github.com/deis/wal-e/pull/3

bacongobbler commented 8 years ago

k, integration tests should fail and the logs will likely show the issue at deis/wal-e#3.

bacongobbler commented 8 years ago

also removing LGTMs and manual testing labels because we discovered an issue, so this PR needs re-evaluation. No manual testing required any more though :8ball:

bacongobbler commented 8 years ago

now it's going green! :tada:

back and ready for review.