search

deis / router

Edge router for Deis Workflow
https://deis.com
MIT License
80 stars 57 forks source link

fix(router): BodySize config can be "0" #218

Closed olalonde closed 8 years ago

olalonde commented 8 years ago

Setting size to 0 disables checking of client request body size.

See http://nginx.org/en/docs/http/ngx_http_core_module.html#client_max_body_size

deis-admin commented 8 years ago

Thanks for the contribution! Please ensure your commits follow our style guide. This code will be tested once a Deis maintainer reviews it.

deis-bot commented 8 years ago

@krancour and @helgi are potential reviewers of this pull request based on my analysis of git blame information. Thanks @olalonde!

Joshua-Anderson commented 8 years ago

Looks like tests are failing because of an assertion that needs to be updated

olalonde commented 8 years ago

Thanks, think I fixed it.

codecov-io commented 8 years ago

Current coverage is 45.24%

Merging #218 into master will not change coverage

@@             master       #218   diff @@
==========================================
  Files             3          3          
  Lines           305        305          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            138        138          
  Misses          162        162          
  Partials          5          5

Powered by Codecov. Last updated by 4024db4...ba2fef4