search

deis / router

Edge router for Deis Workflow
https://deis.com
MIT License
80 stars 57 forks source link

fix(model): check if CertMapping exists #280

Closed bacongobbler closed 8 years ago

bacongobbler commented 8 years ago

This way we're not performing a needless API call to kubernetes.

addresses #212 slightly

deis-bot commented 8 years ago

@krancour, @arschles and @kmala are potential reviewers of this pull request based on my analysis of git blame information. Thanks @bacongobbler!

codecov-io commented 8 years ago

Current coverage is 46.25% (diff: 0.00%)

Merging #280 into master will decrease coverage by 0.15%

@@             master       #280   diff @@
==========================================
  Files             3          3          
  Lines           306        307     +1   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            142        142          
- Misses          160        161     +1   
  Partials          4          4

Powered by Codecov. Last update 9a0d3c8...7c1f99d

ultimateboy commented 8 years ago

Test coverage for this package is added in https://github.com/deis/router/pull/276 (and therefore I'd ignore the codecov rejection)

Depending on which PR is merged first, the tests might not pass. Confirm before merging the second PR.