search

deis / router

Edge router for Deis Workflow
https://deis.com
MIT License
80 stars 57 forks source link

feat(charts): Add support to add annotations during install #288

Closed kmala closed 7 years ago

kmala commented 7 years ago

fixes https://github.com/deis/charts/issues/374

This is useful if any user wants to have default annotations for all his cluster installs by using the same values file for all installs thereby not needing to do custom changes after the install.

codecov-io commented 7 years ago

Current coverage is 55.11% (diff: 100%)

Merging #288 into master will not change coverage

@@             master       #288   diff @@
==========================================
  Files             6          6          
  Lines           381        381          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            210        210          
  Misses          151        151          
  Partials         20         20

Powered by Codecov. Last update 563d731...19466c5

rimusz commented 7 years ago

LGTM, just wording mentioned by @mboersma needs to be fixed