Closed rvadim closed 7 years ago
Thanks for the contribution! Please ensure your commits follow our style guide. This code will be tested once a Deis maintainer reviews it.
@mboersma, @helgi and @krancour are potential reviewers of this pull request based on my analysis of git blame
information. Thanks @rvadim!
@@ master #290 diff @@
==========================================
Files 6 6
Lines 381 382 +1
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 210 211 +1
Misses 151 151
Partials 20 20
Powered by Codecov. Last update 563d731...2f287d0
Jenkins, add to whitelist.
I'd want @jchauncey to have final say on this. This might affect the metrics that are collected from the router.
Yes if you change the router log format in any way you will definitely jack up the router metrics we collect. So while I'm not opposed to this we should have a warning if you change it.
So, any tasks for me here? Need to add warning to log?
@rvadim I think you'd need to add a warning to the documentation for this feature.
Done, but get CI error in infrastructure.
thanks @rvadim!
Hi, This PR add ability for customizing nginx access log format through router deployment annotations.
We need this ability to migrate from deis 1.x.