deis / router

Edge router for Deis Workflow
https://deis.com
MIT License
80 stars 57 forks source link

feat(charts): make hostPort and service type configurable #296

Closed lachie83 closed 7 years ago

deis-bot commented 7 years ago

@kmala is a potential reviewer of this pull request based on my analysis of git blame information. Thanks @lachie83!

lachie83 commented 7 years ago

cc @krancour @slack @gabrtv

codecov-io commented 7 years ago

Current coverage is 55.23% (diff: 100%)

Merging #296 into master will not change coverage

@@             master       #296   diff @@
==========================================
  Files             6          6          
  Lines           382        382          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            211        211          
  Misses          151        151          
  Partials         20         20          

Powered by Codecov. Last update 2152eeb...0fae6d1

krancour commented 7 years ago

Nice improvement.