deis / router

Edge router for Deis Workflow
https://deis.com
MIT License
80 stars 57 forks source link

feat(router): make server_token configurable #301

Closed lachie83 closed 7 years ago

lachie83 commented 7 years ago

http://nginx.org/en/docs/http/ngx_http_core_module.html#server_tokens

Syntax: server_tokens on | off | string;
Default: server_tokens on;
Context: http, server, location
deis-bot commented 7 years ago

@krancour, @ultimateboy and @arschles are potential reviewers of this pull request based on my analysis of git blame information. Thanks @lachie83!

codecov-io commented 7 years ago

Current coverage is 55.35% (diff: 100%)

Merging #301 into master will increase coverage by 0.11%

@@             master       #301   diff @@
==========================================
  Files             6          6          
  Lines           382        383     +1   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            211        212     +1   
  Misses          151        151          
  Partials         20         20          

Powered by Codecov. Last update ee87845...170e853

bacongobbler commented 7 years ago

If you wouldn't mind amending your commit such that it follows the commit style guide, that would be awesome! That way it'll get picked up by deisrel when we generate the release changelog. Thanks!

bacongobbler commented 7 years ago

Thanks for doing this, @lachie83.

lachie83 commented 7 years ago

@bacongobbler updated commit message